feat(wrapper): allow destroy() method to work with functional components #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when calling `wrapper.destroy()`, only non-functional components are removed from the DOM. This PR allows functional components to be removed from the DOM as well.
eddyerburgh
reviewed
Mar 22, 2019
eddyerburgh
reviewed
Mar 22, 2019
eddyerburgh
reviewed
Mar 22, 2019
|
Thanks for this, I'll merge once you've made the changes. Be warned that it might be some time before this is released, as the next version contains many breaking changes |
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when calling
wrapper.destroy(), only non-functional components are removed from the DOM.This PR allows functional components to be removed from the DOM as well.
xref #1185 #1185 (comment)