fix: 🐛 treat isActive to case-insensitive #3657
Conversation
|
Maybe we need to add some tests for this new behavior, any suggestion where to write the new test? |
There was a problem hiding this comment.
This is not the correct patch as there is an option to make the path matching case sensitive and this should respect it.
This information should be available on the route records as regex.ignoreCase or something similar.
Can you also add a few unit tests for isIncludeRoute?
Add the test and use regex.ignoreCase property. Any suggestion on how to safely get ignoreCase properly? |
| @@ -72,10 +72,11 @@ export default { | |||
| ? createRoute(null, normalizeLocation(route.redirectedFrom), null, router) | |||
| : route | |||
|
|
|||
| const ignoreCase = current.matched[0].regex.ignoreCase | |||
There was a problem hiding this comment.
Any suggestion on how to safely get ignoreCase properly? @posva
|
Hello @posva. Any suggestion on this PR? |
✅ Closes: #3656