Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scroll): run scrollBehavior on initial load (fix #3196) #3199

Merged
merged 10 commits into from Jun 18, 2020
Merged

fix(scroll): run scrollBehavior on initial load (fix #3196) #3199

merged 10 commits into from Jun 18, 2020

Conversation

Calvin-LL
Copy link
Contributor

fix #3196 by adding handleScroll to the callback of the first call to history.transitionTo

@posva
Copy link
Member

posva commented May 14, 2020

I will first go through #3172 which might create merge conflicts. This will also require an e2e test

@Calvin-LL
Copy link
Contributor Author

Calvin-LL commented May 14, 2020 •
edited

I will first go through #3172 which might create merge conflicts. This will also require an e2e test

Sounds good I'll go add the e2e tests

@Calvin-LL Calvin-LL mentioned this pull request May 14, 2020
Merged
@Calvin-LL
Copy link
Contributor Author

I will first go through #3172 which might create merge conflicts. This will also require an e2e test

e2e tests added

@Calvin-LL
Copy link
Contributor Author

Calvin-LL commented May 19, 2020 •
edited

I will first go through #3172 which might create merge conflicts. This will also require an e2e test

Merge conflicts are resolved. Looks like Netlify fail to deploy because of 8d26c5d, not related to this PR

@Calvin-LL Calvin-LL changed the title Add handleScroll on initial history.transitionTo (fix #3196) fix(scroll): run scrollBehavior on initial load (fix #3196) Jun 8, 2020
@Mike377
Copy link

Mike377 commented Jun 8, 2020

Is this going to be merged soon? Having the same problem right now.

posva
posva requested changes Jun 12, 2020
View reviewed changes
test/e2e/specs/scroll-behavior.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
posva
posva approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@posva posva merged commit 84398ae into vuejs:dev Jun 18, 2020
@pi0 pi0 mentioned this pull request Aug 14, 2020
Merged
7 tasks
@rtibbles rtibbles mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollBehavior does not run on load
3 participants
@Calvin-LL @posva @Mike377