Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn v2 compat: add vue to peerDependencies #3120

Open
AlexandreBonaventure opened this issue Feb 12, 2020 · 3 comments
Open

Yarn v2 compat: add vue to peerDependencies #3120

AlexandreBonaventure opened this issue Feb 12, 2020 · 3 comments

Comments

@AlexandreBonaventure
Copy link

AlexandreBonaventure commented Feb 12, 2020

Version

3.1.3

Steps to reproduce

When using Typescript, vue-router export types like here: https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact vue should be added to peerDependencies

What is expected?

vue should be a peerDependency

What is actually happening?

it is not, and it fails in a strict dependency-tree context

Ref: vuejs/vue-cli#5135

@posva
Copy link
Member

posva commented Feb 12, 2020

for anybody doing the PR, please include clear steps about how to test locally with links to instructions to use yarn v2 as I personally don't use it

@Blakelist7
Copy link
Contributor

Blakelist7 commented May 21, 2021

@posva I would like to give it a shot.
And also could you guide me a little bit where should I look Into ?

@susnux
Copy link

susnux commented Jun 13, 2023

Generally vue should be a peer dependency as the types files import from vue but vue is neither listed as a dependency nor as a peerDependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants