Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove useless code and comments #2808

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Jun 12, 2019

No description provided.

@@ -36,8 +36,7 @@ const NW_CONFIG = isLocal
? resolve(__dirname, './nightwatch.browserstack.js')
: resolve(__dirname, './nightwatch.config.js')

// add a configuration by default if not provided
// add a configuration by default if not provided
// check configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// check configuration
// check if -c is provided for multiple environments

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 842a760 into vuejs:dev Aug 23, 2019
@vue-bot
Copy link

vue-bot commented Aug 23, 2019

Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants