(fix #2724): Fix active links when parent link redirects to child #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix active parent link when parent link redirects to a child and when the user navigates between child links fix vuejs#2724
posva
force-pushed
the
fix-active-parent-redirect-links
branch
from
ada0165
to
ac7d83c
Compare
|
Hey, sorry for the delay and thanks for this! I changed a bit the test and added more. The Waiting for tests to pass |
|
Thanks again! 💚 |
|
Thank you ! |
This was referenced Aug 29, 2019
This was referenced Sep 30, 2019
This was referenced Oct 26, 2019
This was referenced Jan 20, 2020
This was referenced Feb 6, 2020
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.4
michaelwybraniec/vue-vuex-jwt-authentication-example#2
Open
This was referenced Mar 4, 2020
This was referenced Mar 24, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fix to the issue #2724 .
Reproduction link
https://jsfiddle.net/posva/fj7ywzxv/
Whenever a parent node has a redirect option, the router.resolve method will return the redirected route when given the parent location as argument. This creates a problem when comparing a link route with the current route as the link route will be the route of the redirected component and not the route of the parent component...