(fix #2607): Fix router.back in abstract mode when 2 consecutive same routes appear in history stack #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domino9697
changed the title
Fix abstract mode's router.back() when 2 consecutive same routes appear in the history stack array fix vuejs#2607
posva
force-pushed
the
fix-abstract-history-navigation
branch
from
26af63f
to
a5af53f
Compare
|
I rebased against dev and adapted the code to use an Error object |
|
Hey @Domino9697, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
|
Thank you @posva ! |
This was referenced Aug 29, 2019
This was referenced Sep 30, 2019
This was referenced Oct 26, 2019
This was referenced Jan 20, 2020
This was referenced Feb 5, 2020
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.4
michaelwybraniec/vue-vuex-jwt-authentication-example#2
Open
This was referenced Mar 4, 2020
This was referenced Mar 24, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fix to the issue #2607.
Reproduction link
https://jsfiddle.net/Rocka/bhu5vkn8/3/
In abstract mode, if you try to navigate through your history with the same routes appearing consecutively in your stack history, the history index remains unchanged.
In History or Hash mode, this issue does not appear because history navigation is handled by the browser and not by vue-router. In all modes, we do not want to re-render a page if the current route and the next route are identical. However, in the case of abstract mode, we still need to update the history index whenever the current and next routes are the same since AbstractHistory handles its own history stack.