docs(zh): add more details to resolution flow #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Apr 12, 2019
| @@ -153,4 +153,4 @@ beforeRouteLeave (to, from , next) { | |||
| 9. 导航被确认。 | |||
| 10. 调用全局的 `afterEach` 钩子。 | |||
| 11. 触发 DOM 更新。 | |||
| 12. 用创建好的实例调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数。 | |||
| 12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数，被激活的组件实例会作为回调函数的参数传入 | |||
There was a problem hiding this comment.
Suggested change
| 12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数，被激活的组件实例会作为回调函数的参数传入 | |
| 12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数，被激活的组件实例会作为回调函数的参数传入。 |
posva
changed the title
|
Where is this coming from? Is this also missing in English docs. Translation doesn't give me something readable 🙁 @Justineo |
Justineo
suggested changes
Apr 13, 2019
|
@posva It's clarifying what “with instantiated instances” mean. Basically it's saying: the instantiated instances will serve as the argument of |
Co-authored-by: GU Yiling <justice360@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原文是“用创建好的实例调用
beforeRouteEnter守卫中传给next的回调函数”，用创建好的什么实例？路由实例？英文为“Call callbacks passed to
nextinbeforeRouteEnterguards with instantiated instances”，我认为 call...with 应该是使用其作为调用 callback 参数的意思，而不是用它来调用 callback