Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract mode's router.back() fails if there are 2 consecutive same routes in history stack #2607

Closed
rocka opened this issue Feb 8, 2019 · 1 comment · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Closed

abstract mode's router.back() fails if there are 2 consecutive same routes in history stack #2607

rocka opened this issue Feb 8, 2019 · 1 comment · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Labels
bug has PR
Projects
Longterm

Comments

@rocka
Copy link

rocka commented Feb 8, 2019

Version

3.0.2

Reproduction link

https://jsfiddle.net/Rocka/bhu5vkn8/3/

Steps to reproduce

  1. Click 10. artist
  2. Hit button togglePlayer
  3. Click 10. artist
  4. Hit button back 2 times

What is expected?

route back to /search

What is actually happening?

nothing happend, route and route-view do not change

'cause I didn't figure out how to determine wether the route is going forward or backword, I decided to use abstract mode and traverse the router stack to find out which direction the route is going, then hit into this bug. The demo works fine if change router's mode to hash or history.
@rocka rocka mentioned this issue Feb 8, 2019
Closed
@posva posva changed the title abstract mode's router.back() was aborted when there are 2 same routes in history stack abstract mode's router.back() fails if there are 2 consecutive same routes in history stack Mar 26, 2019
@posva posva added the bug label Mar 26, 2019
@posva posva added this to Doable or in refactor (low prio, low complex) in Longterm Mar 26, 2019
@tarunmangukiya
Copy link

Facing same issue!

Domino9697 added a commit to Domino9697/vue-router that referenced this issue May 17, 2019
@Domino9697
fix(AbstractHistory): Fix router.back in abstract mode
26af63f 
Fix abstract mode's router.back() when 2 consecutive same routes appear in the history stack array

fix vuejs#2607
@Domino9697 Domino9697 mentioned this issue May 17, 2019
Merged
@posva posva added the has PR label May 17, 2019
posva pushed a commit to Domino9697/vue-router that referenced this issue Jul 5, 2019
@Domino9697 @posva
fix(AbstractHistory): Fix router.back in abstract mode
2d0b97d 
Fix abstract mode's router.back() when 2 consecutive same routes appear in the history stack array

fix vuejs#2607
@posva posva closed this as completed in 8910979 Jul 5, 2019
@posva posva moved this from Doable or in refactor (low prio, low complex) to Done in Longterm Jul 5, 2019
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
This was referenced Sep 30, 2019
Merged
Open
This was referenced Oct 26, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Jan 27, 2020
Closed
This was referenced Feb 5, 2020
Merged
Open
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
This was referenced Mar 4, 2020
Open
Open
This was referenced Mar 24, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Merged
This was referenced Apr 15, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has PR
Projects
Longterm
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 mariazevedo88/hash-generator-js
[Snyk] Upgrade vue-router from 3.0.7 to 3.1.3 noprotocol/Bubblicious
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 tghelere/valorize-vidas
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/DeliVuery
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/dailymages
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/vuestore
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 estafette/estafette-ci-web
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.4 santosomar/linux_kernel_cves
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.6 OpenTMI/opentmi-default-gui
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.6 LuisAlejandro/luisalejandro.github.io-legacy
3 participants
@posva @tarunmangukiya @rocka