Warn about root paths without a leading slash (fix #2550) #2591
Conversation
|
@posva Added test cases, moved the change to |
src/create-route-map.js
Outdated
| @@ -34,6 +34,16 @@ export function createRouteMap ( | |||
| } | |||
| } | |||
|
|
|||
| // warn if routes do not include leading slashes | |||
| const pathsMissingSlashes = pathList | |||
| .filter(path => !!path && path.charAt(0) !== '*' && path.charAt(0) !== '/') | |||
There was a problem hiding this comment.
I think a single find is simpler. No need for the map and I don't really understand the last filter call
We can also remove the !!path check as it's a string
There was a problem hiding this comment.
find is much simpler but unfortunately I do not think it's supported by this version of nightwatch which causes e2e tests to fail.
There was a problem hiding this comment.
you are totally right! Thank you for catching that, it would fail on IE as well. Then let's keep the filter and display the list of failing routes since the information is there already. If the routes could be displayed one per line, that would be perfect as it would be more readable (I don't remember how it was before)
There was a problem hiding this comment.
It used to be just comma separated, but one per line sounds better
|
@posva Are you referring to the |
|
Hey @Sayegh7, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
close #2550
This PR creates the following warning message when a root route exists without a leading slash:
This facilitates the debugging process as the current behavior does not generate any warnings or errors.