fix(custom-elements): ensure props are available before initial render (fix #4716)) #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
commented
Oct 13, 2021
| asyncDef().then(resolve) | ||
| asyncDef() | ||
| .then(resolve) | ||
| .then(() => this._update()) |
There was a problem hiding this comment.
This is necessary to have the asyncWrapper's props updated before it renders the nested actual component.
Without this, the async Component test case fails now.
|
Sidenote: I'm not sure yet if this also fixes #4789 as that one doesn't involve a number prop. But I couldn't identify another part of the code that could be responsible yet. |
|
What's holding up this merge request getting approved? |
|
Time |
yyx990803
added a commit
that referenced
this pull request
Nov 2, 2021
|
I refactored the resolve call a bit more and I believe 4b7f76e should be a more efficient fix (it avoids some unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a case where props with type "Number" lead to a premature first render - before the initial component props have been collected from the DOM element properties that have been set.
close #4716