Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): ensure that DeepReadonly handles Ref type properly (fix #4701) #4714

Merged
merged 1 commit into from Oct 7, 2021

Conversation

LinusBorg
Copy link
Member

Without this check, refs are handled like ordinary objects, and the keyof iteration exposes the private RefSymbol which can lead to problems when creating type declarations.

Note: I wasn't sure how to write a test for this as it doesn't happen within the vue-next repo, only in a consuming library that creates a declaration file during buld.
fix #4701

@LinusBorg LinusBorg added scope: types 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: reactivity labels Sep 30, 2021
@github-actions
Copy link

Size report

Path Size
vue.global.prod.js 46.24 KB (0%)
runtime-dom.global.prod.js 30.59 KB (0%)
index.js 18.02 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: reactivity scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating declarations for readonly/shallowReadonly ref causes TS4058 error
2 participants