Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove superfluous spaces when normalizing class #3083

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

nekosaur
Copy link
Contributor

@nekosaur nekosaur commented Jan 21, 2021

Having any other primitive value than string in an array sent to normalizeClass results in extra spaces. In v2 there are no extra spaces.

h('div', {
  class: ['foo', undefined, false, 'bar'],
})

<div class="foo   bar"/>

@HcySunYang HcySunYang self-requested a review January 22, 2021 02:50
Co-authored-by: Jacek Karczmarczyk <jkarczm@gmail.com>
@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Feb 3, 2021
@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Feb 4, 2021
@LinusBorg LinusBorg moved this from Planned, might need fresh review to Approved in Next Patch Feb 4, 2021
@LinusBorg LinusBorg merged commit 4b55142 into vuejs:master Feb 4, 2021
Next Patch automation moved this from Approved to Done Feb 4, 2021
@yyx990803 yyx990803 moved this from Done to Final (Reviewed by Evan) in Next Patch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants