Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): check the DEV_ROOT_FRAGMENT flag correctly in the dev environment #2750

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix(runtime-core): check the DEV_ROOT_FRAGMENT flag correctly in the dev environment #2750

merged 1 commit into from
Feb 5, 2021

Conversation

HcySunYang
Copy link
Member

@HcySunYang HcySunYang commented Dec 7, 2020 •
edited

close: #2741 , #3133
According to #2741 , I think he should not use renderSlot directly, but the cause of the problem lies in:

result.patchFlag & PatchFlags.DEV_ROOT_FRAGMENT

When result.patchFlag is negative(e.g. -2 BAIL), this condition is always true.

@LinusBorg LinusBorg added the ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. label Dec 26, 2020
@afontcu afontcu mentioned this pull request Dec 27, 2020
Closed
afontcu
afontcu approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes a broken test in Vue Test Utils next when trying to upgrade to 3.0.4 👍

@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Jan 6, 2021
@LinusBorg LinusBorg added this to Planned in Next Patch Feb 1, 2021
@LinusBorg LinusBorg moved this from Planned to Approved in Next Patch Feb 1, 2021
@HcySunYang HcySunYang mentioned this pull request Feb 4, 2021
Closed
@LinusBorg LinusBorg linked an issue Feb 5, 2021 that may be closed by this pull request
<transition> with a single, empty child throws an error #3133
Closed
@LinusBorg LinusBorg merged commit 347a879 into vuejs:master Feb 5, 2021
Next Patch automation moved this from Approved to Done Feb 5, 2021
@yyx990803 yyx990803 moved this from Done to Final (Reviewed by Evan) in Next Patch Feb 24, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontcu afontcu afontcu approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
3 participants
@HcySunYang @afontcu @LinusBorg