Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): extract the correct props type for the DateConstructor #2676

Merged
merged 2 commits into from
Feb 5, 2021
Merged

fix(types): extract the correct props type for the DateConstructor #2676

merged 2 commits into from
Feb 5, 2021

Conversation

HcySunYang
Copy link
Member

close: #2668

The reason is in the definition of DateConstructor:

interface DateConstructor {
    ...
    (): string;
    ...
}

For simplicity, we can just create a new judgment branch to deal with it.

@posva
Copy link
Member

posva commented Nov 27, 2020

I think we should add a test in the test-dts folder

@HcySunYang
Copy link
Member Author

yeah added

@vandelpavel vandelpavel mentioned this pull request Dec 28, 2020
Closed
@HcySunYang HcySunYang added this to Planned, might need fresh review in Next Patch Feb 4, 2021
Next Patch automation moved this from Planned, might need fresh review to Approved Feb 4, 2021
@LinusBorg LinusBorg merged commit 48f0d29 into vuejs:master Feb 5, 2021
Next Patch automation moved this from Approved to Done Feb 5, 2021
@yyx990803 yyx990803 moved this from Done to Final (Reviewed by Evan) in Next Patch Feb 23, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting "Date" type as props will infer to string in the setup function
4 participants
@HcySunYang @posva @edison1105 @LinusBorg