add vue 3.2.13+ as peer dependency #1944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry that I have overlooked this repo for a long time. Didn't know this issue even got into Yarn's compatibility database 🤦♂️ |
freddy38510
pushed a commit
to freddy38510/vue-loader
that referenced
this pull request
Nov 17, 2022
Closes vuejs#1944 Should also closes pnpm/pnpm#4941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yyx990803 , I find that vue/compiler-sfc was required explicitly in vue-loader 17+ in line, but when I install vue-loader separately, it did not give me note that vue 3.2.13+ was required (cuz after vue 3.2.13+, @vue/compiler-sfc was installed with it, so compiler-sfc module can be imported with name vue/compiler-sfc).
So I make this pr, hope that others won't get same problem.