Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing default export error #1748

Merged
merged 1 commit into from Oct 27, 2020
Merged

Conversation

thecrypticace
Copy link
Contributor

In webpack 5 + mini-css-extract-plugin you'll see warning about a missing default export. This happens because vue-loader always assumes a default export for style blocks. This only happens in the case of CSS modules.

Closes #1742

Default exports should only be used for CSS modules.
@thecrypticace
Copy link
Contributor Author

The test failure appears unrelated and doesn't happen locally. Any ideas?

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sodatea sodatea merged commit 429a284 into vuejs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting warnings for export 'default' (imported as 'mod') was not found
2 participants