fix: use "api.isRecorded" instead of "module.hot.data"

[liximomo]

We should not use module.hot.data, which is highly unreliable. Plugins like lazy-compile-webpack-plugin use a dummy loader to prevent webpack from building async modules, the module will be compiled and hot-update on demand. In such a case, the module.hot.data is truthy but the record does not exist, which will cause a running error in api.reload. I think api.isRecorded is more reliable and reasonable.

[yyx990803]

Oh nvm... Haha I was looking at the diff without syntax highlighting

[liximomo]

FYI. This PR may also solve this problem.

https://stackoverflow.com/questions/52339206/vuejs-hot-reload-cannot-read-property-ctor-of-undefined.

[yyx990803]

/cc @sodatea let's test this patch in the CLI and publish a patch version.

[sodatea]

Though I'm still struggling to understand why module.hot.data is unreliable (is it because there may be multiple sources of dispose call?), this commit seems to work great.

[liximomo]

@sodatea Hope this pseudo code can provide some insight

compiler.hooks.compilation.tap('LazyCompilePlugin', compilation => {
  compilation.hooks.buildModule.tap('LazyCompilePlugin', wpModule => {
    if (ShouldBlock) {
      // relace the whole loaders
      wpModule.loaders = [
        {
          loader: dummy,
        },
      ];
    } else {
      // restore original loaders
      wpModule.loaders = originLoaders;
      // The same module will be hot-updated, and module.hot.data will be truthy.
      // Since vue-loader has't run before, there are no any records.
    }
  });
});

[sodatea]

@liximomo Thanks! The new version is now available.

[liximomo]

❤️ 🎉