Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jest 25 #229

Merged
merged 6 commits into from Jun 8, 2020
Merged

Support Jest 25 #229

merged 6 commits into from Jun 8, 2020

Conversation

sibiraj-s
Copy link
Contributor

@ghost
Copy link

ghost commented Apr 24, 2020

@JessicaSachs @lmiller1990 can we merge this and release a stable stable version of v4. its been more than a year since the last beta was release. since vue3 is now in beta. it would be nice if this gets a stable release.

see #206

@JessicaSachs
Copy link
Contributor

JessicaSachs commented Apr 24, 2020

We're very aware that Vue 3 is in beta. We're working non-stop on supporting Vue Test Utils for Vue 3 (vtu-next)

RE Stable: The last decision to make is regarding native typescript support and choosing ts-jest or babel-jest for built-in typescript support. Just added #238 for this. We're busy with Vue 3 support so this hasn't gotten attention.

RE Jest 25.x: I'll look at this PR soon. #237 is on my radar to make this kind of stuff easier

@utlime
Copy link

utlime commented Jun 3, 2020

Hi @JessicaSachs , could you please merge this PR, as current version has vulnerability:
https://app.snyk.io/test/npm/ts-jest/24

@lmiller1990 lmiller1990 self-requested a review June 3, 2020 11:10
@lmiller1990
Copy link
Member

I approved. @JessicaSachs we good to merge this and do a minor for vue-jest v3?

@utlime
Copy link

utlime commented Jun 3, 2020

Hey @lmiller1990 , it will be good to release for v4.0.0-beta.3 as we started to use beta version

@lmiller1990
Copy link
Member

Oh yes, that probably makes more sense @utlime.

I will wait for 1-2 days to see @JessicaSachs opinion. Then we can do it.

I think we should make this 4.0.0 release candidate 1 - I don't see any real benefit in dragging this out. I've been using v4 beta for a while and it seems fine ✅

@andrew-ignatiev
Copy link

@lmiller1990 @JessicaSachs . First of all thank you for your great work! Do you have plan to merge it? If so, when community will be able to get it and forget about annoying vulnerability finally? :)

@lmiller1990
Copy link
Member

Right now

@lmiller1990 lmiller1990 merged commit 966dd34 into vuejs:master Jun 8, 2020
@lmiller1990
Copy link
Member

lmiller1990 commented Jun 8, 2020

I will release v4.0.0-beta.3 in an hour or so, waiting on CI and testing a bit.

We need to get into gear and sort this mess out, we have v3, v4 AND v5 (for Vue 3).

Clearly v3 needs to be deprecated, I have literally no idea what the difference is between v3 and v4 (only just joined this repo a month or so ago). v4 seems to work great. v5 (aka next) is also working fine with Vue 3, except source maps are kinda busted, I think. Also no JSX (JSX does not work in Vue 3 yet).

Can someone try upgrading from v3 to v4 and see if anything breaks? It worked fine on my small/medium apps.

@lmiller1990
Copy link
Member

Ok 4.0.0-beta.3 should now be available on NPM.

@lmiller1990
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants