Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallback to default TemplateCompileOptions #310

Merged
merged 2 commits into from Dec 11, 2020

Conversation

nogic1008
Copy link
Collaborator

In #288 PR, transformAssetUrls and transpileOptions are overwrote to {} if vue-jest.templateCompiler option is not provided.
It fails test cases that depend on default TemplateCompileOptions.

This PR:

  • Fallback default TemplateCompileOptions if user does not set it.
  • Add Documentation of templateCompiler option

@lmiller1990
Copy link
Member

lmiller1990 commented Dec 11, 2020

Cool, thanks. I can release this weekend.

Are you interested in helping maintain this repo? I could look to get you added as a collaborator. We have many issues to triage, and improvements to make, especially for 5.x (for Vue 3).

Also, I see you are located in Hamamatsu. I visited it once before, it was nice.

@lmiller1990 lmiller1990 merged commit 4ce4686 into vuejs:master Dec 11, 2020
@nogic1008 nogic1008 deleted the hotfix/template-compiler branch December 11, 2020 10:26
@nogic1008
Copy link
Collaborator Author

@lmiller1990

Are you interested in helping maintain this repo?

Sure. I want to cooperate as much as I can, Thanks.

@lmiller1990
Copy link
Member

@nogic1008 what's your email/discord/twitter? How can I contact you?

@nogic1008
Copy link
Collaborator Author

nogic1008 commented Dec 12, 2020

@lmiller1990

@nogic1008 what's your email/discord/twitter? How can I contact you?

Twitter ID is same as GitHub one. plz contact:
https://twitter.com/nogic1008

@nogic1008
Copy link
Collaborator Author

@lmiller1990
When will this fix be released to v4?

@lmiller1990
Copy link
Member

lmiller1990 commented Feb 24, 2021

Done - sorry about that. This should be available on npm under vue-jest@4.0.0.

https://github.com/vuejs/vue-jest/releases/tag/v4.0.0

I think we should move the latest tag to 4.0.0 instead of 3.x on npm, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants