Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: set hashFunction to xxhash64 to fix Node 17 compatibility #6781

Merged
merged 1 commit into from Oct 25, 2021

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Oct 25, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Technically it's a breaking change, though not very significant.

Other information:

@sodatea sodatea merged commit f986340 into vuejs:dev Oct 25, 2021
@sodatea sodatea deleted the fix-node17 branch October 25, 2021 14:24
@C0kkie
Copy link

C0kkie commented Oct 27, 2021

Can we also get a backport to v4?

@sodatea
Copy link
Member Author

sodatea commented Oct 27, 2021

No, xxhash64 is only supported in webpack 5.54.0+

@C0kkie
Copy link

C0kkie commented Oct 27, 2021

is the beta already good to use or

@sodatea
Copy link
Member Author

sodatea commented Oct 28, 2021

It's mostly stable. No drastic breaking changes are planned.

@horans
Copy link

horans commented Oct 28, 2021

Ran into Digest method not supported with Node v17.01/16.13 + vue-cli v5.0.0-beta.7 with official plugins.
Had to fallback to node v16.13 + vue-cli v5.0.0-beta.7 with all the plugins but beta.6 vue/cli-service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants