feat(cli-plugin-eslint): use ESLint class instead of CLIEngine

[ota-meshi]

This PR replaces CLIEngine with the ESLint class.
CLIEngine will be removed in eslint v8 and must be replaced with the ESLint class to support eslint v8.

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Underlying tools
• Other, please describe:

Does this PR introduce a breaking change? (check one)

• Yes
• No

Options may be affected by this change, but should not affect the options listed in the README.
https://github.com/vuejs/vue-cli/tree/dev/packages/%40vue/cli-plugin-eslint#readme

Other information:

[sodatea]

With

env: ['overrideConfig', 'env'],
global: ['overrideConfig', 'globals'],

--env browser --global window gets normalized to

{
  overrideConfig: {},
  env: ['browser'],
  globals: ['window']
}

Is this the intended result?
Because in my understanding, env and globals should be put under overrideConfig.

[ota-meshi]

That's a bug. sorry I will fix it 😓

[ota-meshi]

Thank you for your review!
I changed this PR. Could you check it again?

[fangbinwei]

It's a little disappointing that cli-plugin-eslint need to do some repetitive work (translateOptions) what ESLint has done. 😢

https://github.com/eslint/eslint/blob/16034f09ae6c7a78b8268b4c859928f18de7b9d6/lib/cli.js#L62
https://github.com/eslint/eslint/blob/16034f09ae6c7a78b8268b4c859928f18de7b9d6/lib/cli.js#L232

[ota-meshi]

It's failing in CI, but looking at the logs it looks like it's succeeding. Could you re-run and check if the test succeeds again?

[sodatea]

😅It's actually a bug in my previous tests. I've fixed it in the dev branch.

The PR looks good to me now, so don't mind the tests, I'll merge it.

[ramicohen303]

When is this supposed to be merged and released? ESLint 8.0 is out, so upgrading my Vue projects to the latest ESLint version breaks my builds.

[sodatea]

It's already released in 5.0.0-beta.5

[ramicohen303]

It's already released in 5.0.0-beta.5

Thank you for the quick reply. When do you expect v5 to be GA?

[sodatea]

I can't give a guaranteed date because I've missed my own deadline multiple times.
But this time I'm targeting November.

[Flygenring]

Will this be released to the 4.x line as well? I was happy to see a new release today thinking I could upgrade ESLint too, but to no avail.

If not, would there be any other way of enabling ESLint 8.0 while using Vue CLI 4.x?

[Stanzilla]

@ota-meshi any news about the v4 backport?

[Javier1995]

"devDependencies": {
    "@sentry/webpack-plugin": "1.20.0",
    "@vue/cli-plugin-babel": "4.5.19",
    "@vue/cli-plugin-eslint": "4.5.19",
    "@vue/cli-plugin-router": "4.5.19",
    "@vue/cli-plugin-vuex": "4.5.19",
    "@vue/cli-service": "4.5.19",
    "@vue/compiler-sfc": "3.2.45",
    "@babel/eslint-parser": "7.19.1",
    "eslint": "8.32.0",
    "eslint-plugin-vue": "9.9.0",
    "prettier": "2.8.1",
ss-loader": "8.0.2"
  }

 ERROR  Failed to compile with 1 error                                                                                                                                                                                          11:55:28 AM

Syntax Error: TypeError: eslint.CLIEngine is not a constructor


You may use special comments to disable some warnings.
Use // eslint-disable-next-line to ignore the next line.
Use /* eslint-disable */ to ignore all warnings in a file.

Having same issue