Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mayProxy.isPublicFileRequest judgment #5693

Merged
merged 1 commit into from Aug 14, 2020

Conversation

Blacate
Copy link
Contributor

@Blacate Blacate commented Jul 18, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
if the proxy path is /, isPublicFileRequest will be /path/to/project/dist/ which is always exist by fs.existSync(isPublicFileRequest). Therefore, it is also necessary to determine whether isPublicFileRequest is a file.

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sodatea sodatea merged commit 0146001 into vuejs:dev Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants