Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e-webdriverio): add e2e plugin for WebdriverIO #5479

Merged
merged 9 commits into from Jul 31, 2020

Conversation

christian-bromann
Copy link
Contributor

@christian-bromann christian-bromann commented May 14, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

This PR adds a new e2e option to run tests using WebdriverIO:

demo

I am happy to be help triaging and fixing all issues that users might create using this plugin. I am the WebdriverIO maintainer and invested in the usability of this.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@sodatea
Copy link
Member

sodatea commented May 16, 2020

Thanks for the pull request!

As we are very close to the next scheduled feature release, I'm not able to review such a big piece of code in the next few days.

I'll take a look later and hope to fit it into the next feature release (scheduled in June).

@christian-bromann
Copy link
Contributor Author

Any updates on this?

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the package-lock.json file because we use yarn for development.

packages/@vue/cli-plugin-e2e-webdriverio/README.md Outdated Show resolved Hide resolved
packages/@vue/cli-plugin-e2e-webdriverio/package.json Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Contributor Author

@sodatea thanks for the review. I updated the PR according to your suggestions.

@christian-bromann
Copy link
Contributor Author

@sodatea please let me know if there is anything missing.

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got the time to further review this PR…
Sorry for the delayed response.

Just a few more fixes to get the plugin in better shape.

@christian-bromann
Copy link
Contributor Author

@sodatea thanks for the review. I addressed the comments and also added WebdriverIO to the docs (english only). The build is failing due to connectivity issues, let's rerun them.

@sodatea
Copy link
Member

sodatea commented Jul 31, 2020

Seems the build isn't failing because of network issues. But somehow yarn cannot resolve the * version range specified in a workspace package's dependencies. Let's copy the ones from the nightwatch plugin as a workaround

"chromedriver": "^81.0.0",
"geckodriver": "^1.19.1",

(I will update them in a batch later, so don't mind the chrome version being too old)

@christian-bromann
Copy link
Contributor Author

@sodatea thanks for the tip. Looks all good now.

@sodatea
Copy link
Member

sodatea commented Jul 31, 2020

Thanks!

@sodatea sodatea merged commit 87e9d42 into vuejs:dev Jul 31, 2020
@christian-bromann christian-bromann deleted the cb-wdio-plugin branch August 2, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants