Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve): pass devServer sockPath properly to client #4800

Merged
merged 1 commit into from May 14, 2020

Conversation

AlbertBrand
Copy link
Contributor

@AlbertBrand AlbertBrand commented Nov 5, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

When you change the devServer.sockPath setting, one of the required webpack-devserver-client ignores the sockPath setting. This is visible in your developer console: the local sockjs url connects but the network sockjs fails.

This is caused by incorrectly providing the sockPath to the webpack client. It infers the host and port from the provided URL parameter but not the sockPath, which has to be specified as an additional parameter. This PR removes the path part from the sockjsUrl (as it does nothing) and adds the sockPath as additional param.

@sodatea sodatea merged commit 96dfd58 into vuejs:dev May 14, 2020
@McPo
Copy link

McPo commented May 14, 2020

Whats the normal release schedule for vue-cli, is there anything in particular that would trigger a patch release? As Id like to know how long I can expect until this fix is released.

Cheers,
Emmet

@sodatea
Copy link
Member

sodatea commented May 14, 2020

Need to clean up some other stuff.

I'll ship a release (4.4.0, under the next dist-tag first) next Monday, and move it to latest around Wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants