feat(typescript): add an option to not rename all .js files to .ts and to set allowJs to true
#4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
changed the title
vue add @vue/typescript - give users a choice to enable allowJs:true modeallowJs: true
NataliaTepluhina
changed the title
allowJs: trueallowJs to true`
NataliaTepluhina
changed the title
allowJs to true`allowJs to true
NataliaTepluhina
changed the title
allowJs to trueallowJs to true
NataliaTepluhina
changed the title
allowJs to trueallowJs to true
pksunkara
reviewed
Jul 1, 2019
pksunkara
reviewed
Jul 1, 2019
sodatea
approved these changes
Jul 2, 2019
sodatea
reviewed
Jul 2, 2019
sodatea
approved these changes
Jul 3, 2019
sodatea
pushed a commit
that referenced
this pull request
Jul 3, 2019
Close #2676 At the moment when we run `vue add`, Vue CLI renames all `*.js` files to `*.ts`. This PR introduces two new prompts on `@vue/cli-plugin-typescript` late-invokation: 1. `convertJsToTs`: if set to `true`, renames all `.js` files to `.ts`. Otherwise renames only `main.js` -> `main.ts`; 2. `allowJs`: if set to `true`, adds `allowJs: true` to TSConfig compiler options. (cherry picked from commit 38debb4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close #2676
At the moment when we run
vue add, Vue CLI renames all*.jsfiles to*.ts. This PR introduces two new prompts on@vue/cli-plugin-typescriptlate-invokation:convertJsToTs: if set totrue, renames all.jsfiles to.ts. Otherwise renames onlymain.js->main.ts;allowJs: if set totrue, addsallowJs: trueto TSConfig compiler options.