New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint v8 support (and the removal of eslint-formatter-codeframe used by default by CLI v5 beta.5) #6740
Comments
Let's just use the built-in one. |
👍 Which one should we use? https://eslint.org/docs/user-guide/formatters/ |
ESLint's default |
Sounds good. If that's OK with you, I'll open PRs to:
|
Yeah, thanks for the help! In the case of |
Let's start with that then! Please see vuejs/eslint-config-typescript#34 to update eslint-config-typescript to eslint v8 |
`eslint-formatter-codeframe` is no longer provided by eslint v8, and must be isntalled separately. As the dependency is not actively maintained, we switch the default formatter to the built-in `stylish` one. See https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#removed-formatters Refs vuejs#6740
As a seconde step: PR to switch to stylish formatter #6748 |
Third and last step: PR to update new projects to eslint v8 #6749 Note that some plugins are not yet officially compatible with eslint v8, but it looks like it works according to the tests added. |
Version
5.0.0-beta.5
Reproduction link
github.com
Environment info
Steps to reproduce
What is expected?
The linting command succeeds
What is actually happening?
The linting command throws:
With the work recently done, eslint v8 nearly works out of the box, except for the codeframe formatter issue, as it has been removed from eslint v8 (see https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#removed-formatters).
Installing the missing dependency fixes the issue.
Maybe the CLI should install directly? I can work on a PR to bump eslint to v8 and typescript-eslint to v5, and add the missing dependency.
Or maybe the default formatter should change to a built-in one? https://eslint.org/docs/user-guide/formatters/
The text was updated successfully, but these errors were encountered: