Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for the language attribute value for <html> on creating new project #6409

Closed
farhadnowzari opened this issue Apr 9, 2021 · 2 comments
Closed

Ask for the language attribute value for <html> on creating new project #6409

farhadnowzari opened this issue Apr 9, 2021 · 2 comments

Comments

@farhadnowzari
Copy link

farhadnowzari commented Apr 9, 2021 •
edited

What problem does this feature solve?

It happens that developers will create a project with vue-cli and they won't notice that vue has an index.html file which has set the language attribute of the tag to "en" by default and it is really easy to be overlooked.
If while installation vue asks about what language to be set on the html tag would be nice.
We recently had problem with one of our Vue apps and some of the customers had complained that why the texts are so bad or are they copy-pasted. Then we found out that since it is set to english by default google was translating a german text from english to german and it was causing a work like "Hell" in german which means "Light" being translated to "Hölle".

What does the proposed API look like?

Please enter the html tag language attribute(default: en):
@fangbinwei
Copy link
Collaborator

vue has an index.html file which has set the language attribute of the tag to "en" by default

This default behavior has been revised by #5992

@farhadnowzari
Copy link
Author

That's is nice but I don't think setting to empty string would be enough.
Just ask that while creating a new project would do to it.
Because the empty string can still be simply overlooked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fangbinwei @farhadnowzari