Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint version check during @vue/cli-plugin-eslint upgrade #5533

Closed
service-paradis opened this issue May 28, 2020 · 2 comments
Closed

ESLint version check during @vue/cli-plugin-eslint upgrade #5533

service-paradis opened this issue May 28, 2020 · 2 comments

Comments

@service-paradis
Copy link

Version

4.4.1

Environment info

Environment Info:

  System:
    OS: Windows 10 10.0.18363
    CPU: (8) x64 Intel(R) Xeon(R) CPU E3-1505M v6 @ 3.00GHz
  Binaries:
    Node: 10.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.15.2 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.18362.449.0
  npmPackages:
    @chenfengyuan/vue-qrcode: ^1.0.2 => 1.0.2
    @fortawesome/vue-fontawesome: ^0.1.9 => 0.1.9
    @types/vuex-i18n: ^1.13.0 => 1.13.0
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.1.2
    @vue/babel-preset-app:  4.4.1
    @vue/babel-preset-jsx:  1.1.2
    @vue/babel-sugar-functional-vue:  1.1.2
    @vue/babel-sugar-inject-h:  1.1.2
    @vue/babel-sugar-v-model:  1.1.2
    @vue/babel-sugar-v-on:  1.1.2
    @vue/cli-overlay:  4.4.1
    @vue/cli-plugin-babel: ^4.4.1 => 4.4.1
    @vue/cli-plugin-eslint: ^4.4.1 => 4.4.1
    @vue/cli-plugin-pwa: ^4.4.1 => 4.4.1
    @vue/cli-plugin-router: ^4.4.1 => 4.4.1
    @vue/cli-plugin-typescript: ^4.4.1 => 4.4.1
    @vue/cli-plugin-unit-jest: ^4.4.1 => 4.4.1
    @vue/cli-plugin-vuex: ^4.4.1 => 4.4.1
    @vue/cli-service: ^4.4.1 => 4.4.1
    @vue/cli-shared-utils:  4.4.1
    @vue/component-compiler-utils:  3.1.2
    @vue/eslint-config-prettier: ^6.0.0 => 6.0.0
    @vue/eslint-config-typescript: ^5.0.2 => 5.0.2
    @vue/preload-webpack-plugin:  1.1.1
    @vue/test-utils: ^1.0.3 => 1.0.3
    @vue/web-component-wrapper:  1.2.0
    @websanova/vue-auth: ^2.21.15-beta => 2.21.15-beta
    eslint-plugin-vue: ^6.2.2 => 6.2.2
    jest-serializer-vue: ^2.0.2 => 2.0.2
    typescript: ~3.9.3 => 3.9.3
    vue: ^2.6.11 => 2.6.11
    vue-axios: ^2.1.5 => 2.1.5
    vue-class-component: ^7.2.3 => 7.2.3
    vue-cli-webpack:  1.0.0
    vue-debounce: ^2.5.5 => 2.5.5
    vue-eslint-parser:  7.0.0
    vue-extend-layout: ^2.0.6 => 2.0.6
    vue-hot-reload-api:  2.3.4
    vue-infinite-loading: ^2.4.5 => 2.4.5
    vue-jest:  3.0.5
    vue-loader:  15.9.2
    vue-meta: ^2.3.4 => 2.3.4
    vue-property-decorator: ^8.4.2 => 8.4.2
    vue-router: ^3.2.0 => 3.2.0
    vue-style-loader:  4.1.2
    vue-svg-inline-loader: ^1.5.0 => 1.5.0
    vue-template-compiler: ^2.6.11 => 2.6.11
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.4.0 => 3.4.0
    vuex-class: ^0.3.2 => 0.3.2
    vuex-class-state2way: ^1.0.1 => 1.0.1
    vuex-i18n: ^1.13.1 => 1.13.1

Steps to reproduce

  • Use eslint@7.1.0
  • Use vue upgrade to install @vue/cli-service@4.4.1

What is expected?

The upgrade should run without warning about ESLint version.

What is actually happening?

A misleading warning is displayed and we need to answer a question before continuing.

Your current ESLint version is v7.
The lastest major version is v6.
Do you want to upgrade? (May contain breaking changes)
@sodatea
Copy link
Member

sodatea commented May 28, 2020

😅 Yeah that's really misleading. Thanks for reporting!

@zhenya-zhu
Copy link
Contributor

@sodatea Here is a PR #5545 , temporarily fix it. Haven't try to fit eslint v7 since a lot of deps need to update, and some of them seems in alpha phase

@sodatea sodatea closed this as completed in 1d0dede Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants