Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dots not supported in scopes #4510

Closed
ma-jahn opened this issue Aug 28, 2019 · 2 comments
Closed

Dots not supported in scopes #4510

ma-jahn opened this issue Aug 28, 2019 · 2 comments

Comments

@ma-jahn
Copy link
Contributor

ma-jahn commented Aug 28, 2019

Version

3.10.0

Environment info

 System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.10.2 - ~/.nvm/versions/node/v10.15.3/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
    Safari: 12.1.2
  npmGlobalPackages:
    @vue/cli: 3.8.2

Steps to reproduce

Create a plugin wuth a name like @some.package/vue-cli-plugin-test

This plugin won't be recognized by vue-cli's reolvePlugin function.

What is expected?

The plugin will be recognized, is listed within vue-cli-service help and is executable.

What is actually happening?

Plugin is being skipped since it doesn't match pluginRE (shared-utils/lib/pluginResolution.js)


Changing pluginRE to something like:

^(@vue\/|vue-|@[\w-]+(\.)?[\w-]+\/vue-)cli-plugin-

should do the trick

@ma-jahn
Copy link
Contributor Author

ma-jahn commented Aug 29, 2019

PR is now available:
#4512

@sodatea
Copy link
Member

sodatea commented Sep 25, 2019

Closing as it's fixed since 4.0 rc.1

@sodatea sodatea closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants