From 96890b526fb1496cc621d01a992118f3e6b2e2bf Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Mon, 21 Oct 2019 17:20:23 +0800 Subject: [PATCH] fix: do not install core plugins that have major version bumps (#4720) * fix: fix version check for core plugins in v4 * fix: fix the error when the diff result is null --- packages/@vue/cli/lib/Creator.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/@vue/cli/lib/Creator.js b/packages/@vue/cli/lib/Creator.js index 4cf69ce44b..78c4dd9077 100644 --- a/packages/@vue/cli/lib/Creator.js +++ b/packages/@vue/cli/lib/Creator.js @@ -129,8 +129,13 @@ module.exports = class Creator extends EventEmitter { const { current, latest } = await getVersions() let latestMinor = `${semver.major(latest)}.${semver.minor(latest)}.0` - // if using `next` branch of cli - if (semver.gte(current, latest) && semver.prerelease(current)) { + if ( + // if the latest version contains breaking changes + /major/.test(semver.diff(current, latest)) || + // or if using `next` branch of cli + (semver.gte(current, latest) && semver.prerelease(current)) + ) { + // fallback to the current cli version number latestMinor = current } // generate package.json with plugin dependencies