From 271bf395df6604c063dbc69b2f5c8cbfdf7ec0af Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Tue, 18 Jun 2019 23:28:26 +0800 Subject: [PATCH] chore: move yorkie from cli-service to plugin-eslint & plugin-typescript (#4153) It is because yorkie is not used anywhere in @vue/cli-service, but only included for the `lintOn: 'commit'` feature of eslint & typescript plugin. Also, a lot of global installation issues are caused by the yorkie postinstall script. Moving it out of the dependency chain of `@vue/cli` mitigates such issues. --- packages/@vue/cli-plugin-eslint/package.json | 3 ++- packages/@vue/cli-plugin-typescript/package.json | 3 ++- packages/@vue/cli-service/package.json | 3 +-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/@vue/cli-plugin-eslint/package.json b/packages/@vue/cli-plugin-eslint/package.json index f2d4b9772a..0dfaf40d4d 100644 --- a/packages/@vue/cli-plugin-eslint/package.json +++ b/packages/@vue/cli-plugin-eslint/package.json @@ -26,7 +26,8 @@ "@vue/cli-shared-utils": "^4.0.0-alpha.1", "eslint-loader": "^2.1.2", "globby": "^9.2.0", - "webpack": ">=4 < 4.29" + "webpack": ">=4 < 4.29", + "yorkie": "^2.0.0" }, "peerDependencies": { "eslint": ">= 1.6.0" diff --git a/packages/@vue/cli-plugin-typescript/package.json b/packages/@vue/cli-plugin-typescript/package.json index 8f62be9435..1bf4166ef8 100644 --- a/packages/@vue/cli-plugin-typescript/package.json +++ b/packages/@vue/cli-plugin-typescript/package.json @@ -29,7 +29,8 @@ "globby": "^9.2.0", "ts-loader": "^6.0.1", "tslint": "^5.16.0", - "webpack": ">=4 < 4.29" + "webpack": ">=4 < 4.29", + "yorkie": "^2.0.0" }, "peerDependencies": { "typescript": ">=2" diff --git a/packages/@vue/cli-service/package.json b/packages/@vue/cli-service/package.json index 4a9847a009..45a90b204c 100644 --- a/packages/@vue/cli-service/package.json +++ b/packages/@vue/cli-service/package.json @@ -77,8 +77,7 @@ "webpack-bundle-analyzer": "^3.3.2", "webpack-chain": "^6.0.0", "webpack-dev-server": "^3.4.1", - "webpack-merge": "^4.2.1", - "yorkie": "^2.0.0" + "webpack-merge": "^4.2.1" }, "peerDependencies": { "vue-template-compiler": "^2.0.0"