Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow links in the homepage-layout features #984

Closed
4 tasks done
HarryAllen1 opened this issue Jul 14, 2022 · 2 comments
Closed
4 tasks done

Allow links in the homepage-layout features #984

HarryAllen1 opened this issue Jul 14, 2022 · 2 comments
Labels
enhancement New feature or request theme Related to the theme

Comments

@HarryAllen1
Copy link

Is your feature request related to a problem? Please describe.

Currently, if the layout of a page is home, under features, links do not render (both markdown and html).

Describe the solution you'd like

Allow markdown links in features
Example:

---
layout: home
title: Ipsum
features:
    - title: [link](https://google.com/)
      details: [another link](https://google.com/)
---

Describe alternatives you've considered

Alternatively, HTML links could be allowed:

---
layout: home
title: Ipsum
features:
    - title: <a href="https://google.com/">link</a>
      details: <a href="https://google.com/">another link</a>
---

Additional context

No response

Validations

@brc-dd brc-dd added the enhancement New feature or request label Jul 14, 2022
@brc-dd
Copy link
Member

brc-dd commented Jul 14, 2022

Fixing this is simple, we just need to use v-html="foo" instead of {{ foo }} syntax in VPFeature.vue. But might need to add styles for links to distinguish them:

image

@brc-dd brc-dd added theme Related to the theme enhancement New feature or request and removed enhancement New feature or request labels Jul 14, 2022
@remirobichet
Copy link

Is this enhancement under developement ?

Another solution would be to let {{ foo }} syntax in VPFeature.vue and add extra optional property to feature section.
For example link as in the hero section and add a CTA at the end of each feature item.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

No branches or pull requests

3 participants