Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): sort multiple sidebars #1552

Merged
merged 9 commits into from Oct 29, 2022

Conversation

userquin
Copy link
Collaborator

This PR will allow use any order in the configuration when multiple sidebars overlap: added small sort splitting the sidebar keys by slash and using the lenght in the sort.

closes #1551

@userquin
Copy link
Collaborator Author

I need to add a test...

@userquin userquin marked this pull request as draft October 28, 2022 22:20
@userquin userquin marked this pull request as ready for review October 28, 2022 23:26
@userquin
Copy link
Collaborator Author

I have no idea why it is failing on CI: rn also failing on my local (Windows).

@brc-dd brc-dd merged commit db1c343 into vuejs:main Oct 29, 2022
@userquin userquin deleted the feat/multiple-sidebars-ordering branch October 29, 2022 08:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple sidebar may require manual sort
2 participants