Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add useWebFonts option #1531

Merged
merged 4 commits into from Oct 24, 2022
Merged

feat(build): add useWebFonts option #1531

merged 4 commits into from Oct 24, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 24, 2022

fixes #1523

@brc-dd brc-dd merged commit c9f04e0 into main Oct 24, 2022
@brc-dd brc-dd deleted the webfonts branch October 24, 2022 16:21
@rijkvanzanten
Copy link
Contributor

Hi @brc-dd! Just wanted to give you a heads up that the change to font-synthesis: style is causing the Italics to be very slanted 🤔 Is this intentional? I can open an Issue if not 🙂 :

CleanShot 2022-11-04 at 13 53 43@2x

@rijkvanzanten
Copy link
Contributor

(Example above is in Arc Version 0.74.1 (35450), Chromium Engine Version 107.0.5304.88. I don't have the Inter font installed on my Mac)

@brc-dd
Copy link
Member Author

brc-dd commented Nov 4, 2022

Yeah, I was working on something too yesterday and saw this. IG we can revert that option to default to none and inside the webfont-marker we can set it as style. (Inter on Google Fonts has no italics.)

@brc-dd
Copy link
Member Author

brc-dd commented Nov 4, 2022

Feel free to create a PR, or I will do it tomorrow (it's nearly midnight at my place).

@rijkvanzanten
Copy link
Contributor

Feel free to create a PR, or I will do it tomorrow (it's nearly midnight at my place).

I'm currently moving so I'm not sure if I can get to doing much actual coding either 😁 Whoever gets to it first!

@rijkvanzanten
Copy link
Contributor

Also relying on Google Fonts hosted fonts for Inter might have some other nastier downsides, but lets have that discussion on #1523 (comment) instead 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use web fonts on web containers
2 participants