Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): support links in homepage features (#984) #1404

Merged
merged 9 commits into from Oct 31, 2022

Conversation

Jimmylxue
Copy link
Contributor

@Jimmylxue Jimmylxue commented Sep 27, 2022

About PR

Thanks for checking

Now, the features configuration on the home page is very beautiful, but sometimes we need to be able to jump to the specified articles for some features。

just like actions config on the home page, now just need to add "link" config that we can jump to other page。

The configuration is modified as follows

---
layout: home

features:
  - icon: ⚡️
    title: vitepress
    details: hello world
    link: https://github.com/vuejs/vitepress
  - icon: 🖖
    title: vue
    details: Thanks for checking
  - icon: 🛠️
    title: TypeScript
    details:Thanks for checking
    link: https://github.com/vuejs/vitepress
---

Link is an optional configuration. It remains unchanged by default when it is not configured

@Jimmylxue Jimmylxue changed the title ✨ homePage feature support jump page feat(theme) ✨ homePage feature support jump page Sep 27, 2022
@brc-dd brc-dd changed the title feat(theme) ✨ homePage feature support jump page feat(theme): support links in homepage features Oct 13, 2022
@brc-dd brc-dd requested a review from kiaking October 13, 2022 16:42
@brc-dd
Copy link
Member

brc-dd commented Oct 13, 2022

I suppose we need either this or #1070. Let Kia decide what's best. The difference between these is this PR makes whole feature a link, while the other PR adds a button in it.

@Jimmylxue
Copy link
Contributor Author

fine~,I didn't know that pr existed。
I just think it is necessary. I added links and corresponding effect animations to the whole body, not through buttons.
Thank you for your reply。

@yuetaibai
Copy link

Link for the homepage is very useful feature, when could it be merged into dev version, please update the progress, wait for use, thanks

@Jimmylxue Jimmylxue marked this pull request as draft October 29, 2022 04:15
@Jimmylxue Jimmylxue marked this pull request as ready for review October 29, 2022 04:20
@kiaking
Copy link
Member

kiaking commented Oct 31, 2022

Yes, I'll take this over. Sorry for the delay!

@kiaking
Copy link
Member

kiaking commented Oct 31, 2022

I've updated the design, and also added linkText feature too 🚀

Screen Shot 2022-10-31 at 18 31 24

@kiaking kiaking changed the title feat(theme): support links in homepage features feat(theme): support links in homepage features (#984) Oct 31, 2022
@Jimmylxue
Copy link
Contributor Author

I've updated the design, and also added linkText feature too 🚀

Screen Shot 2022-10-31 at 18 31 24

that's awesome!

@kiaking kiaking merged commit 84b4abc into vuejs:main Oct 31, 2022
@yuetaibai
Copy link

Great, thanks for the update !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants