Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): add built-in global component Badge. #1239

Merged
merged 13 commits into from Oct 31, 2022

Conversation

szsascha
Copy link
Contributor

@szsascha szsascha commented Aug 25, 2022

fixes open changes from #1134 since there is no progress anymore and some people really want this feature

close #1134
close #1156

@yansongda
Copy link

looking forward...

@yansongda
Copy link

Any updates please?

@kiaking
Copy link
Member

kiaking commented Sep 14, 2022

I'll look into this!

@szsascha
Copy link
Contributor Author

@kiaking How is it going?

@kiaking kiaking self-assigned this Oct 20, 2022
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the styles to match VitePress's custom container, and made few adjustment.

  • remove vertical since the difference was trivial. We could add it back if we get high demand.
  • change error -> danger to be consistent with custom container.

@kiaking
Copy link
Member

kiaking commented Oct 31, 2022

@brc-dd I've updated the docs! Could you take a final look? If it looks OK, please merge it! 🙌

@brc-dd brc-dd merged commit ac8619f into vuejs:main Oct 31, 2022
@richardo2016
Copy link
Contributor

richardo2016 commented Nov 5, 2022

fixes open changes from #1134 since there is no progress anymore and some people really want this feature

close #1134 close #1156

It's suprising that those changes could be merged. I thought this feature wouldn't be accepted due to the consideration here, so I stopped watching the #1134, I feel very sorry.

Anyway, thx for @szsascha @kiaking ! ♪(・ω・)ノ it's nice of you to take another PR and make it better.

@Goozoon
Copy link

Goozoon commented Nov 10, 2022

@brc-dd I've updated the docs! Could you take a final look? If it looks OK, please merge it! 🙌

Doesnt look to be rendered in my test env

@brc-dd
Copy link
Member

brc-dd commented Nov 10, 2022

@Goozoon Can you share a minimal reproducible example? It is working fine on our deployed docs. You might not have extended the default theme properly.

@Goozoon
Copy link

Goozoon commented Nov 10, 2022

Pure vanilla Yarn Init thingy and copy=paste from the docs to see the result. Nothing about "extended the default theme" in the docs.

@Goozoon Can you share a minimal reproducible example? It is working fine on our deployed docs. You might have not extended the default theme properly.

@brc-dd
Copy link
Member

brc-dd commented Nov 10, 2022

@Goozoon It's working fine for me: https://stackblitz.com/edit/vite-wbmmgk?file=docs%2Findex.md If it's not for you, feel free to open a new issue with details. Also, can you check if you're on the latest VitePress version?

@Goozoon
Copy link

Goozoon commented Nov 11, 2022

let me check yours.. thank you

@Goozoon
Copy link

Goozoon commented Nov 11, 2022

my fault:

yarn docs:dev -> vitepress v1.0.0-draft.8

in dependencies:

"devDependencies": {
"vitepress": "^1.0.0-alpha.28",

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge feature
7 participants