refactor: use markdown title plugin and remove parseHeader utils #1235
+36
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
Aug 24, 2022
brc-dd
reviewed
Aug 24, 2022
brc-dd
approved these changes
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the
parseHeader/deeplyParseHeaderutils are totally removed. We don't need to maintain the complex regexp-based parsing anymore.Instead, we use markdown-it to resolve the title, or parse the
frontmatter.title. It is safer and more accurate, and has better compatibility with other markdown-it plugins. For example, we don't need extra process formarkdown-it-attrsas before.