Skip to content

refactor: externalize markdown headers plugin #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

meteorlxy
Copy link
Member

No description provided.

@brc-dd
Copy link
Member

brc-dd commented Aug 24, 2022

Regarding this header plugin, do we actually need it? Because we're just using it for the aside outline, but using headers extracted from markdown is preventing users from using dynamic headers (having Vue-style interpolations / added using some component). In future, we'll probably need to make that component client-only so that it can handle such headings.

There shouldn't be any need at our side of this, but I am not sure if people are using this stuff. It was never publicly exposed though. In (useData) docs too, VitePressData has no headers property.

EDIT:

It looks like the vuejs/theme repo is using this stuff, so lets keep it. In the default theme, we can just update the component, keeping data stuff same.

@brc-dd brc-dd merged commit 71358eb into vuejs:main Aug 24, 2022
@meteorlxy meteorlxy deleted the md/headers branch August 24, 2022 18:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants