Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Register typescript commands in takeover mode #2361

Closed
zardoy opened this issue Feb 7, 2023 · 0 comments · Fixed by #3788
Closed

[proposal] Register typescript commands in takeover mode #2361

zardoy opened this issue Feb 7, 2023 · 0 comments · Fixed by #3788
Labels
enhancement New feature or request

Comments

@zardoy
Copy link
Contributor

zardoy commented Feb 7, 2023

The request is to register command IDs listed below so:

  1. User don't need to create second keymap for the same commands when takeover mode is enabled
  2. Preserve compatibility with other extensions (eg commands.run pipelines)

All in all why don't just do this? The only case I know that can cause warnings is that when builtin typescript extension is enabled after takeover mode was enabled, but we can un-register commands then?

The only command I actually care is only typescript.tsserverRequest for API. I believe it was already discussed hundred of times, but AFAIK this is the only to communicate with TS plugin (pass and receive arbitrary data).

Also ideally handle all commands:

  • typescript.findAllFileReferences -> volar.vue.findAllFileReferences
  • typescript.goToProjectConfig -> volar.openTsConfig
  • typescript.goToSourceDefinition -> ?
  • typescript.organizeImports -> ?
  • typescript.removeUnusedImports -> ?
  • typescript.selectTypeScriptVersion -> volar.selectTypeScriptVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants