Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No/broken support for declaration maps in takeover mode. #2340

Closed
filimon-danopoulos-stratsys opened this issue Jan 27, 2023 · 8 comments · Fixed by volarjs/volar.js#24
Closed
Labels
enhancement New feature or request

Comments

@filimon-danopoulos-stratsys

I have a typescript project that emits type declarations and declaration maps. When I use takeover mode, "F12" does not take me to source code as defined in the declaration map but rather the .d.ts file. When I use the builtin typescript language service this works as intended.

@gunhaxxor
Copy link

I can confirm this behaviour on my end. Seems like a rather important bug to me 🤔

@filimon-danopoulos-stratsys
Copy link
Author

It is mostly annoying since take over mode is the preferred (and quite heavily pushed) way of running Volar. It could be argued that is not very pressing since the type definitions work.

@johnsoncodehk
Copy link
Member

Can you try "volar.vueserver.noProjectReferences": true? See #1344 (comment)

@filimon-danopoulos-stratsys
Copy link
Author

With Volar takeover mode enabled and the setting proposed in .vscode/settings.json it does not not work for me. Tried restarting Volar and VSCode but made no difference.

Not sure if it makes any difference but the .d.ts and corresponding .d.ts.map files are in an npm-package.

@gunhaxxor
Copy link

Same here. Unfortunately not working in a monorepo with several typescript projects/packages
image

@patroza
Copy link

patroza commented Feb 3, 2023

same here, really annoying, especially when onboarding new people.
the problem is the same in non take-over mode, when trying to follow links from within .vue files.

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Feb 19, 2023
@blake-newman
Copy link
Member

should be resolved with: volarjs/volar.js#24

@gustavotoyota
Copy link

I'm having this problem as well. Is there a workaround I can use right now?
I'm trying to use @blake-newman's solution, but I can't find know to test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants