From 951af24980fbfa2a2867c3d302ececed0583b267 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sun, 4 Jul 2021 09:23:25 +0900
Subject: [PATCH 1/2] Update `vue/no-boolean-default` rule to support `<script
 setup>`

---
 lib/rules/no-boolean-default.js       | 120 ++++++++++-------
 tests/lib/rules/no-boolean-default.js | 186 ++++++++++++++++++++++++++
 2 files changed, 254 insertions(+), 52 deletions(-)

diff --git a/lib/rules/no-boolean-default.js b/lib/rules/no-boolean-default.js
index e278e3011..6b1f44e74 100644
--- a/lib/rules/no-boolean-default.js
+++ b/lib/rules/no-boolean-default.js
@@ -9,6 +9,7 @@ const utils = require('../utils')
 /**
  * @typedef {import('../utils').ComponentArrayProp} ComponentArrayProp
  * @typedef {import('../utils').ComponentObjectProp} ComponentObjectProp
+ * @typedef {import('../utils').ComponentTypeProp} ComponentTypeProp
  */
 
 // ------------------------------------------------------------------------------
@@ -29,31 +30,10 @@ function isBooleanProp(prop) {
 }
 
 /**
- * @typedef {ComponentObjectProp & { value : ObjectExpression }} ObjectExpressionProp
+ * @param {ObjectExpression} propDefValue
  */
-
-/**
- * @param {(ComponentArrayProp | ComponentObjectProp)[]} props
- * @returns {ObjectExpressionProp[]}
- */
-function getBooleanProps(props) {
-  return props.filter(
-    /**
-     * @param {ComponentArrayProp | ComponentObjectProp} prop
-     * @returns {prop is ObjectExpressionProp}
-     */
-    (prop) =>
-      prop.value != null &&
-      prop.value.type === 'ObjectExpression' &&
-      prop.value.properties.some(isBooleanProp)
-  )
-}
-
-/**
- * @param {ObjectExpressionProp} propDef
- */
-function getDefaultNode(propDef) {
-  return utils.findProperty(propDef.value, 'default')
+function getDefaultNode(propDefValue) {
+  return utils.findProperty(propDefValue, 'default')
 }
 
 module.exports = {
@@ -73,42 +53,78 @@ module.exports = {
   },
   /** @param {RuleContext} context */
   create(context) {
-    return utils.executeOnVueComponent(context, (obj) => {
-      const props = utils.getComponentProps(obj)
-      const booleanProps = getBooleanProps(props)
-
-      if (!booleanProps.length) return
-
-      const booleanType = context.options[0] || 'no-default'
-
-      booleanProps.forEach((propDef) => {
-        const defaultNode = getDefaultNode(propDef)
+    const booleanType = context.options[0] || 'no-default'
+    /**
+     * @param {ComponentArrayProp | ComponentObjectProp | ComponentTypeProp} prop
+     * @param { { [key: string]: Expression | undefined } } [withDefaultsExpressions]
+     */
+    function processProp(prop, withDefaultsExpressions) {
+      if (prop.type === 'object') {
+        if (prop.value.type !== 'ObjectExpression') {
+          return
+        }
+        if (!prop.value.properties.some(isBooleanProp)) {
+          return
+        }
+        const defaultNode = getDefaultNode(prop.value)
+        if (!defaultNode) {
+          return
+        }
+        verifyDefaultExpression(defaultNode.value)
+      } else if (prop.type === 'type') {
+        if (prop.types.length !== 1 || prop.types[0] !== 'Boolean') {
+          return
+        }
+        const defaultNode =
+          withDefaultsExpressions && withDefaultsExpressions[prop.propName]
         if (!defaultNode) {
           return
         }
+        verifyDefaultExpression(defaultNode)
+      }
+    }
+    /**
+     * @param {(ComponentArrayProp | ComponentObjectProp | ComponentTypeProp)[]} props
+     * @param { { [key: string]: Expression | undefined } } [withDefaultsExpressions]
+     */
+    function processProps(props, withDefaultsExpressions) {
+      for (const prop of props) {
+        processProp(prop, withDefaultsExpressions)
+      }
+    }
+
+    /**
+     * @param {Expression} defaultNode
+     */
+    function verifyDefaultExpression(defaultNode) {
+      switch (booleanType) {
+        case 'no-default':
+          context.report({
+            node: defaultNode,
+            message:
+              'Boolean prop should not set a default (Vue defaults it to false).'
+          })
+          break
 
-        switch (booleanType) {
-          case 'no-default':
+        case 'default-false':
+          if (defaultNode.type !== 'Literal' || defaultNode.value !== false) {
             context.report({
               node: defaultNode,
-              message:
-                'Boolean prop should not set a default (Vue defaults it to false).'
+              message: 'Boolean prop should only be defaulted to false.'
             })
-            break
-
-          case 'default-false':
-            if (
-              defaultNode.value.type !== 'Literal' ||
-              defaultNode.value.value !== false
-            ) {
-              context.report({
-                node: defaultNode,
-                message: 'Boolean prop should only be defaulted to false.'
-              })
-            }
-            break
+          }
+          break
+      }
+    }
+    return utils.compositingVisitors(
+      utils.executeOnVueComponent(context, (obj) => {
+        processProps(utils.getComponentProps(obj))
+      }),
+      utils.defineScriptSetupVisitor(context, {
+        onDefinePropsEnter(node, props) {
+          processProps(props, utils.getWithDefaultsPropExpressions(node))
         }
       })
-    })
+    )
   }
 }
diff --git a/tests/lib/rules/no-boolean-default.js b/tests/lib/rules/no-boolean-default.js
index 7421a049d..7035f9450 100644
--- a/tests/lib/rules/no-boolean-default.js
+++ b/tests/lib/rules/no-boolean-default.js
@@ -229,6 +229,102 @@ ruleTester.run('no-boolean-default', rule, {
         }
       `,
       options: ['default-false']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      defineProps({
+        foo: {
+          type:Boolean
+        }
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser')
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      defineProps({
+        foo: {
+          type:Boolean,
+          default: false
+        }
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      options: ['default-false']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: boolean
+      }
+      withDefaults(defineProps<Props>(), {
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      }
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: boolean
+      }
+      withDefaults(defineProps<Props>(), {
+        foo: false
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      },
+      options: ['default-false']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: boolean | string
+      }
+      withDefaults(defineProps<Props>(), {
+        foo: false
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      }
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: string
+      }
+      withDefaults(defineProps<Props>(), {
+        foo: false
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      }
     }
   ],
 
@@ -314,6 +410,96 @@ ruleTester.run('no-boolean-default', rule, {
           line: 6
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      defineProps({
+        foo: {
+          type:Boolean,
+          default: false
+        }
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      errors: [
+        {
+          message:
+            'Boolean prop should not set a default (Vue defaults it to false).',
+          line: 6
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      defineProps({
+        foo: {
+          type:Boolean,
+          default: true
+        }
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      options: ['default-false'],
+      errors: [
+        {
+          message: 'Boolean prop should only be defaulted to false.',
+          line: 6
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: boolean
+      }
+      withDefaults(defineProps<Props>(), {
+        foo: false
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      },
+      errors: [
+        {
+          message:
+            'Boolean prop should not set a default (Vue defaults it to false).',
+          line: 7
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      interface Props {
+        foo: boolean
+      }
+      withDefaults(defineProps<Props>(), {
+        foo: true
+      })
+      </script>
+      `,
+      parser: require.resolve('vue-eslint-parser'),
+      parserOptions: {
+        parser: require.resolve('@typescript-eslint/parser')
+      },
+      options: ['default-false'],
+      errors: [
+        {
+          message: 'Boolean prop should only be defaulted to false.',
+          line: 7
+        }
+      ]
     }
   ]
 })

From 62e73ac1d6403fd6c3f8446e360320941c369315 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sun, 4 Jul 2021 09:49:42 +0900
Subject: [PATCH 2/2] Fix test

---
 tests/lib/rules/no-boolean-default.js | 68 +++++++++++++++------------
 1 file changed, 38 insertions(+), 30 deletions(-)

diff --git a/tests/lib/rules/no-boolean-default.js b/tests/lib/rules/no-boolean-default.js
index 7035f9450..ef1af7925 100644
--- a/tests/lib/rules/no-boolean-default.js
+++ b/tests/lib/rules/no-boolean-default.js
@@ -8,6 +8,7 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
+const semver = require('semver')
 const rule = require('../../../lib/rules/no-boolean-default')
 
 const RuleTester = require('eslint').RuleTester
@@ -453,9 +454,15 @@ ruleTester.run('no-boolean-default', rule, {
         }
       ]
     },
-    {
-      filename: 'test.vue',
-      code: `
+    ...(semver.lt(
+      require('@typescript-eslint/parser/package.json').version,
+      '4.0.0'
+    )
+      ? []
+      : [
+          {
+            filename: 'test.vue',
+            code: `
       <script setup lang="ts">
       interface Props {
         foo: boolean
@@ -465,21 +472,21 @@ ruleTester.run('no-boolean-default', rule, {
       })
       </script>
       `,
-      parser: require.resolve('vue-eslint-parser'),
-      parserOptions: {
-        parser: require.resolve('@typescript-eslint/parser')
-      },
-      errors: [
-        {
-          message:
-            'Boolean prop should not set a default (Vue defaults it to false).',
-          line: 7
-        }
-      ]
-    },
-    {
-      filename: 'test.vue',
-      code: `
+            parser: require.resolve('vue-eslint-parser'),
+            parserOptions: {
+              parser: require.resolve('@typescript-eslint/parser')
+            },
+            errors: [
+              {
+                message:
+                  'Boolean prop should not set a default (Vue defaults it to false).',
+                line: 7
+              }
+            ]
+          },
+          {
+            filename: 'test.vue',
+            code: `
       <script setup lang="ts">
       interface Props {
         foo: boolean
@@ -489,17 +496,18 @@ ruleTester.run('no-boolean-default', rule, {
       })
       </script>
       `,
-      parser: require.resolve('vue-eslint-parser'),
-      parserOptions: {
-        parser: require.resolve('@typescript-eslint/parser')
-      },
-      options: ['default-false'],
-      errors: [
-        {
-          message: 'Boolean prop should only be defaulted to false.',
-          line: 7
-        }
-      ]
-    }
+            parser: require.resolve('vue-eslint-parser'),
+            parserOptions: {
+              parser: require.resolve('@typescript-eslint/parser')
+            },
+            options: ['default-false'],
+            errors: [
+              {
+                message: 'Boolean prop should only be defaulted to false.',
+                line: 7
+              }
+            ]
+          }
+        ])
   ]
 })