Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove eslint internal traverser #910

Merged
merged 4 commits into from Jun 24, 2019
Merged

refactor: remove eslint internal traverser #910

merged 4 commits into from Jun 24, 2019

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jun 22, 2019

eslin@6 has moved traverser.js to lib/shared

eslint/eslint#11555

@fisker fisker mentioned this pull request Jun 22, 2019
Merged
@fisker fisker mentioned this pull request Jun 22, 2019
Closed
@fisker
Copy link
Contributor Author

fisker commented Jun 22, 2019

@mysticatea

@g-plane
Copy link
Contributor

g-plane commented Jun 22, 2019 •
edited

However, using internal code of ESLint isn't safe, and it can be changed even in semver-patch release.

@fisker
Copy link
Contributor Author

fisker commented Jun 22, 2019

@g-plane I understand the risk, any good idea?

@g-plane
Copy link
Contributor

g-plane commented Jun 22, 2019

IMHO, using a third-party traverser package like @babel/traverser may be for workaround.

@paulgv paulgv mentioned this pull request Jun 22, 2019
Merged
1 task
@pimlie pimlie mentioned this pull request Jun 22, 2019
Merged
1 task
@Baune8D Baune8D mentioned this pull request Jun 22, 2019
Closed
@Baune8D
Copy link

Baune8D commented Jun 22, 2019 •
edited

typescript-eslint has solved a similar problem in this issue: typescript-eslint/typescript-eslint#563

They seem to have replaced traverser.js with a custom implementation.

@mysticatea
Copy link
Member

Thank you for your contribution.

I think require("vue-eslint-parser").AST.traverse() is better.

@yi-ge
Copy link

yi-ge commented Jun 23, 2019

Thank you.

@fisker
Copy link
Contributor Author

fisker commented Jun 23, 2019 •
edited

@mysticatea it's ready for review

@fisker fisker changed the title fix traverser.js location for eslint@6 refactor: remove eslint internal traverser Jun 23, 2019
@FloEdelmann FloEdelmann mentioned this pull request Jun 23, 2019
Merged
mysticatea
mysticatea approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@mysticatea mysticatea merged commit 9efcb6a into vuejs:master Jun 24, 2019
@vue-bot
Copy link

vue-bot commented Jun 24, 2019

Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@fisker fisker mentioned this pull request Jun 24, 2019
Merged
@fisker fisker deleted the fix-traverser branch June 24, 2019 11:40
mysticatea pushed a commit that referenced this pull request Jun 24, 2019
@fisker @mysticatea
fix: remove eslint internal traverser (#910)
082c03d
@gabegorelick gabegorelick mentioned this pull request Sep 6, 2019
Closed
prigaux added a commit to UnivParis1/annuaire that referenced this pull request Jan 5, 2020
@prigaux
migrate to vue-cli 4
1cc373d 
- needed to have fix vuejs/eslint-plugin-vue#910
- adapt to core-js@3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fisker @g-plane @Baune8D @mysticatea @yi-ge @vue-bot