Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: improve editor style in vuepress #717

Merged
merged 1 commit into from Dec 30, 2018
Merged

Chore: improve editor style in vuepress #717

merged 1 commit into from Dec 30, 2018

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 8, 2018 •
edited

The bottom padding of the interactive code examples seems a little excessive and I think might also be increasing a little with each line in the initial code.

#534 (review)

After: https://armano2.github.io/eslint-plugin-vue/rules/no-dupe-keys.html
Before: https://vuejs.github.io/eslint-plugin-vue/rules/no-dupe-keys.html

image

@armano2 armano2 self-assigned this Dec 8, 2018
@armano2 armano2 changed the title chore: improve editor style in vuepress Chore: improve editor style in vuepress Dec 8, 2018
mysticatea
mysticatea approved these changes Dec 30, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 1331d41 into vuejs:master Dec 30, 2018
@armano2 armano2 deleted the improve-editor-style branch December 30, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@chrisvfritz chrisvfritz chrisvfritz approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees

@armano2 armano2

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armano2 @mysticatea @chrisvfritz @ota-meshi