Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: move component-name-in-template-casing rule to uncategorized #703

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

mysticatea
Copy link
Member

This PR moves component-name-in-template-casing to uncategorized from strongly-recommended category.

There are some reasons:

  1. This rule can break user code by autofix. If a user uses x-element Web Component, the rule breaks it. To avoid this broken, the user needs to configure ignores option. Therefore, this rule doesn't fit vue/strongly-recommended preset.
  2. There is a bikeshedding. ⭐️New: Add vue/component-name-in-template-casing #397 (comment), ⭐️New: Add vue/component-name-in-template-casing #397 (comment), Beta 5 brakes linter #691 (comment), and Beta 5 brakes linter #691 (comment). Users which use kebab-casing is much and our style guide allows it.

@armano2
Copy link
Collaborator

armano2 commented Dec 9, 2018

@mysticatea i'm unsure if its not better to go for #714 with registeredComponentsOnly set to true by default

@mysticatea
Copy link
Member Author

I still want to move it to uncategorized because it needs additional configuration for people which use popular libraries.

@mysticatea mysticatea merged commit b1346cd into master Dec 30, 2018
@mysticatea mysticatea deleted the move-component-name-in-template-casing branch December 30, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants