-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add prettier config #698
Conversation
your gitconfig has wrong username/email :> |
we should also propose update to https://github.com/prettier/eslint-config-prettier/blob/master/vue.js |
Thank you for this PR. The name Also we need the document about the preset. |
Good idea @mysticatea I realised after I started creating PR to Damn, good catch @armano2 - I ran docs deploy and it must've changed my config. |
Theoretically information about config could stay in prettier documentation. If you're going to configure prettier yourself, this is where this information should be present. And if you'll decide to use @vue/config-prettier - you'll be all set, without ever having to worry about turning any rules off @mysticatea . What do you think? |
1b21d3d
to
f2a7640
Compare
Change prettier config name to no-layout-rules
f2a7640
to
268e6a9
Compare
@michalsnik do you mind enabling require-meta-type rule in config. its required to make this work correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LGTM.
Just to be sure. Which is the correct This is what I have now (but it seems to report no errors at all):
|
This looks fine @alexschomb. Can you show full config, how do you run eslint, does the problem exist if you run eslint through terminal? Also what versions of these packages are you using? |
This PR adds automatic generation for
prettier
config, that disables alllayout
rules. We're going to use this config in@vue/eslint-config-prettier
as well as probably update information in prettier docs to point to this config, instead of a not-synced version that is currently provided.