Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/v-on-handler-style rule and deprecate vue/v-on-function-call rule #2009

Merged
merged 18 commits into from Oct 30, 2022
Merged

Add vue/v-on-handler-style rule and deprecate vue/v-on-function-call rule #2009

merged 18 commits into from Oct 30, 2022

Conversation

ota-meshi
Copy link
Member

This PR adds vue/v-on-handler-style rule.
And deprecates vue/v-on-function-call rule.

close #2001

@FloEdelmann FloEdelmann mentioned this pull request Oct 12, 2022
Closed
FloEdelmann
FloEdelmann requested changes Oct 12, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review without having looked at the code yet.

docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Show resolved Hide resolved
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
tests/lib/rules/v-on-handler-style.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann requested changes Oct 20, 2022
View reviewed changes
docs/rules/v-on-handler-style.md Show resolved Hide resolved
docs/rules/v-on-handler-style.md Show resolved Hide resolved
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
lib/rules/v-on-handler-style.js Outdated Show resolved Hide resolved
lib/rules/v-on-handler-style.js Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Show resolved Hide resolved
@ota-meshi
Copy link
Member Author

Thank you for your review.
I made a change to this PR other than ignoreIncludesComment.

FloEdelmann
FloEdelmann reviewed Oct 28, 2022
View reviewed changes
docs/rules/v-on-handler-style.md Outdated Show resolved Hide resolved
docs/rules/v-on-handler-style.md Show resolved Hide resolved
ota-meshi and others added 2 commits October 28, 2022 16:46
FloEdelmann
FloEdelmann approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM

@ota-meshi ota-meshi merged commit f5d700c into master Oct 30, 2022
@ota-meshi ota-meshi deleted the v-on-handler-style branch October 30, 2022 14:26
This was referenced May 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edit v-on-function-call to enforce @click="() => fn()" over @click="fn()" and @click="fn"
2 participants
@ota-meshi @FloEdelmann