Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent option to vue/padding-line-between-tags #1982

Merged
merged 5 commits into from Sep 30, 2022

Conversation

dev1437
Copy link
Contributor

@dev1437 dev1437 commented Sep 19, 2022

For #1978

@FloEdelmann FloEdelmann linked an issue Sep 19, 2022 that may be closed by this pull request
@FloEdelmann FloEdelmann changed the title Add consistent configuration Add consistent option to vue/padding-line-between-tags Sep 19, 2022
lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 28, 2022

Updated @ota-meshi let me know if anything else

lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 29, 2022

Changes done @ota-meshi, nice job

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing all the feedback!

@ota-meshi ota-meshi merged commit cae6d29 into vuejs:master Sep 30, 2022
@dev1437 dev1437 deleted the padding-line-between-tags/consistent branch February 7, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/padding-line-between-tags with new 'consistent' option
3 participants