Chore: ts-parser support in demo #1972
Conversation
| parser: this.typescript | ||
| ? this.tsEslintParser | ||
| : this.langTs | ||
| ? { | ||
| ts: this.tsEslintParser, | ||
| typescript: this.tsEslintParser | ||
| } | ||
| : null, |
There was a problem hiding this comment.
It's really hard to read this. Can we extract part of this to a separate variable to make it more readable? Or use if? Or configure Prettier to allow parentheses here?
Also, is the second check really needed? Or can we always set the TS parser for the ts and typescript blocks?
There was a problem hiding this comment.
Thank you for review!
I would like to rewrite this and write comments.
this.typescript is intended to be used when using ts code blocks.
The this.langTs condition is used during <script lang="ts"> or <script lang="typescript">. <script lang="typescript"> is not currently used, but I think someone may PR a new rule to enforce it in the future.
.eslintrc.js
Outdated
| @@ -131,7 +131,8 @@ module.exports = { | |||
| 'unicorn/no-useless-undefined': 'off', | |||
| 'unicorn/prefer-optional-catch-binding': 'off', // not supported by current ESLint parser version | |||
| 'unicorn/prefer-module': 'off', | |||
| 'unicorn/prevent-abbreviations': 'off' | |||
| 'unicorn/prevent-abbreviations': 'off', | |||
| 'unicorn/no-nested-ternary': 'off' // conflicts with Prettier | |||
There was a problem hiding this comment.
But it makes the code more readable than Prettier 🙈
This PR modifies the documentation site demo so that it parses well using typescript.
https://deploy-preview-1972--eslint-plugin-vue.netlify.app/rules/valid-define-emits.html
https://deploy-preview-1972--eslint-plugin-vue.netlify.app/rules/valid-define-props.html
We'll need to clear the cache in netlify for this to take effect.
Related to #1968 (comment)