Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create padding-line-between-tags rule #1966

Merged
merged 44 commits into from Sep 16, 2022
Merged

Create padding-line-between-tags rule #1966

merged 44 commits into from Sep 16, 2022

Conversation

dev1437
Copy link
Contributor

@dev1437 dev1437 commented Sep 10, 2022

Add rule for #1832

@FloEdelmann FloEdelmann linked an issue Sep 10, 2022 that may be closed by this pull request
Rule proposal: padding-lines-between-tags #1832
Closed
4 tasks
@FloEdelmann
Copy link
Member

Could you please have a look at the CI failures?

FloEdelmann
FloEdelmann requested changes Sep 10, 2022
View reviewed changes
docs/rules/space-between-siblings.md Outdated Show resolved Hide resolved
lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
tests/lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
tests/lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
tests/lib/rules/space-between-siblings.js Outdated Show resolved Hide resolved
ota-meshi
ota-meshi reviewed Sep 10, 2022
View reviewed changes
docs/rules/README.md Outdated Show resolved Hide resolved
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 10, 2022

Anything else? Let me know @ota-meshi @FloEdelmann thank you

@dev1437
Copy link
Contributor Author

dev1437 commented Sep 11, 2022

Hi @ota-meshi let me know if there's anything else. Maybe more test cases that you can think of or improvement for docs? Thanks

@FloEdelmann FloEdelmann changed the title Create space-between-siblings rule Create padding-line-between-tags rule Sep 11, 2022
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 12, 2022

Hi @ota-meshi I've updated the rule, let me know if anything else thank you

ota-meshi
ota-meshi requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! I tested the autofix and found some bugs.

docs/rules/padding-line-between-tags.md Outdated Show resolved Hide resolved
lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 13, 2022

Hi @ota-meshi thank you for finding those bugs, I've patched them, let me know if you come across any others.

ota-meshi
ota-meshi requested changes Sep 15, 2022
View reviewed changes
lib/rules/padding-line-between-tags.js Outdated Show resolved Hide resolved
@dev1437
Copy link
Contributor Author

dev1437 commented Sep 15, 2022 •
edited

Fixed, let me know if anything else thank you @ota-meshi

ota-meshi
ota-meshi approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you!

@ota-meshi ota-meshi merged commit bf9b95c into vuejs:master Sep 16, 2022
@dev1437 dev1437 deleted the rule/space-between-siblings branch September 16, 2022 10:10
This was referenced Sep 16, 2022
Open
Closed
This was referenced May 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: padding-lines-between-tags
3 participants
@dev1437 @FloEdelmann @ota-meshi